An empty method is generally considered bad practice and can lead to confusion, readability, and maintenance issues. Empty methods bring no
functionality and are misleading to others as they might think the method implementation fulfills a specific and identified requirement.
There are several reasons for a method not to have a body:
- It is an unintentional omission, and should be fixed to prevent an unexpected behavior in production.
- It is not yet, or never will be, supported. In this case an exception should be thrown.
- The method is an intentionally-blank override. In this case a nested comment should explain the reason for the blank override.
Exceptions
This does not raise an issue in the following cases:
- Arrow functions as they can denote default values.
- Functions with a name starting with the prefix
on like onClick.
- Functions whose name includes
noop.
- Constructors as it is already covered by S6647.
static defaultProps = {
listStyle: () => {}
};
function onClick() {
}
function myNoopFunction() {
}
class C {
constructor() {}
}
